Skip to content

Conversation

@jeremykubica
Copy link
Collaborator

@jeremykubica jeremykubica commented Nov 25, 2025

Change how the GivenValueList and the TableSampler behave in the context of distributed computation:

  • GivenValueList stays stateful and should be used for testing only. Pickling and running in parallel is disabled.
  • TableSampler becomes stateless (with appropriate documentation). It supports running in distributed mode.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.57%. Comparing base (97460dc) to head (306c1e3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/lightcurvelynx/math_nodes/given_sampler.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   94.59%   94.57%   -0.02%     
==========================================
  Files          63       63              
  Lines        5494     5497       +3     
==========================================
+ Hits         5197     5199       +2     
- Misses        297      298       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Before [f065d17] After [351bd76] Ratio Benchmark (Parameter)
6.74±0.1ms 6.85±0.1ms 1.02 benchmarks.TimeSuite.time_lightcurve_source
553±10μs 560±10μs 1.01 benchmarks.TimeSuite.time_apply_passbands
127±3μs 128±4μs 1.01 benchmarks.TimeSuite.time_evaluate_simple_linear_wavelength_model
47.8±1μs 48.4±1μs 1.01 benchmarks.TimeSuite.time_make_new_salt3_model
30.0±0.3μs 30.3±0.2μs 1.01 benchmarks.TimeSuite.time_make_simple_linear_wavelength_model
73.9±0.6ms 74.1±1ms 1 benchmarks.TimeSuite.time_additive_multi_model_source
7.60±0.1ms 7.63±0.1ms 1 benchmarks.TimeSuite.time_apply_white_noise
43.0±0.7ms 42.8±0.4ms 1 benchmarks.TimeSuite.time_make_and_evaluate_static_sed
101±1μs 101±1μs 1 benchmarks.TimeSuite.time_make_and_evaluate_step_model
13.1±0.2μs 13.1±0.2μs 1 benchmarks.TimeSuite.time_sample_x1_from_hostmass

Click here to view all benchmarks.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jeremykubica jeremykubica requested a review from hombit December 1, 2025 19:49
@jeremykubica jeremykubica marked this pull request as ready for review December 1, 2025 19:49
@jeremykubica jeremykubica merged commit ad010e5 into main Dec 1, 2025
8 of 9 checks passed
@jeremykubica jeremykubica deleted the graph_state_shard branch December 1, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants